Skip to content

chore(ai-review): adopt pr-reviewer v1.3.0 native_loop + org-var tokens#374

Merged
joryirving merged 1 commit into
mainfrom
chore/pr-reviewer-v1.3.0-native-loop
Jun 15, 2026
Merged

chore(ai-review): adopt pr-reviewer v1.3.0 native_loop + org-var tokens#374
joryirving merged 1 commit into
mainfrom
chore/pr-reviewer-v1.3.0-native-loop

Conversation

@joryirving

Copy link
Copy Markdown
Contributor

Canary for the misospace v1.3.0 fanout.

Changes

  • Pin pr-reviewer-action v1.2.9 → v1.3.0 (3479bf5).
  • tool_mode plan_execute_loopnative_loop — the v1.3.0 flagship multi-hop tool-calling harness (the reviewer gathers its own evidence: read files, grep, fetch, with an in-conversation verdict). Requires v1.3.0 for streaming + the verdict turn.
  • ai_max_tokens${{ vars.AI_MAX_TOKENS || '16000' }} — org-wide variable so token budget is tuned once across misospace (16000 fallback until the org var is set).
  • Thinking-model loop budgets: tool_planning_max_tokens 1500 → 16000 (1500 truncates a reasoning model on every loop turn → empty content → spurious escalation), tool_planning_timeout_sec 45 → 300 (longer streamed turns), and new tool_loop_wall_clock_sec 300 (default 120 is short for the slow self-hosted reviewer).

Why a canary

native_loop on the self-hosted Gemma reviewer is slower and more token-hungry per review than the 2-round planner. This validates the config (no truncation/escalation, reviews land clean) on one repo before fanning out to KubeTix / miso-chat / miso-gallery / windowstead.

pull_request runs the head workflow, so this PR self-validates the new config.

🤖 Generated with Claude Code

- Bump the action pin v1.2.9 → v1.3.0 (3479bf5).
- Switch tool_mode plan_execute_loop → native_loop (the v1.3.0 flagship
  multi-hop tool-calling harness; requires v1.3.0 for streaming + the
  in-conversation verdict).
- Wire ai_max_tokens to an org-wide variable: ${{ vars.AI_MAX_TOKENS || '16000' }}
  so it can be tuned once across the misospace org (16000 fallback until set).
- Raise the per-turn loop budget for the thinking model: tool_planning_max_tokens
  1500 → 16000 (1500 truncates a reasoning model every loop turn), and
  tool_planning_timeout_sec 45 → 300 for longer streamed turns; add
  tool_loop_wall_clock_sec 300 (default 120 is short for the slow self-hosted
  reviewer).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@its-saffron its-saffron Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — escalated (fast_low_confidence)

Review: PR PR 374 — Adopt pr-reviewer v1.3.0 native_loop + org-var tokens

Summary

This is a canary PR that upgrades the AI PR review workflow to use pr-reviewer-action v1.3.0 with the new native_loop tool mode, org-wide token variable (AI_MAX_TOKENS), and relaxed timing budgets. The change is scoped to one file (.github/workflows/ai-pr-review.yaml) and introduces no code changes.

Change-by-Change Findings

Change Assessment
Pin bump: @4126a27@3479bf5 (v1.2.9 → v1.3.0) Confirmed valid via GitHub Releases API — v1.3.0 published 2026-06-15 by PR author.
tool_mode: plan_execute_loopnative_loop Backward-compatible per upstream release notes: "tool_mode: native_loop is opt-in, and existing plan_execute_loop / off consumers are unaffected."
ai_max_tokens: new `${{ vars.AI_MAX_TOKENS
tool_planning_timeout_sec: 45 → 300 Rationale documented in PR body: longer for streamed turns on self-hosted reviewer.
tool_planning_max_tokens: 1500 → 16000 Rationale: "1500 truncates a reasoning model on every loop turn → empty content → spurious escalation."
tool_loop_wall_clock_sec: new 300 New parameter added by v1.3.0; default 120 is short for the slow self-hosted reviewer.

Standards Compliance

  • No secrets committed: Uses ${{ secrets.LITELLM_API_KEY }} and ${{ vars.* }} appropriately — no credentials in diff.
  • API routes / workflow config: N/A — this is a GitHub Actions workflow file, not an API route.
  • Error handling / validation: N/A — configuration-only change.
  • Prisma schema: N/A — no database changes.
  • Release process: This PR is itself the canary validation step before a broader fan-out. If CI passes, the pattern is validated for other repos in the org.

Linked Issue Fit

No linked issues present in the PR body.

Evidence Provider Findings

Tool harness confirmed:

  • misospace/pr-reviewer-action v1.3.0 release exists and is tagged at commit 3479bf5.
  • Release title: "Native tool-calling review harness" — the native_loop mode allows the model to chain tool calls natively.
  • Release is additive and backward-compatible — no breaking changes to existing plan_execute_loop or off consumers.

Tool Harness Findings

Both API calls succeeded:

  • GET /repos/misospace/pr-reviewer-action/releases — returned v1.3.0 as latest.
  • GET /repos/misospace/pr-reviewer-action/releases/tags/v1.3.0 — confirmed tag at commit 3479bf5 matching the pinned SHA.

CI Check Results

  • Docker Build: ✅ success
  • Validate: ✅ success

Both required checks passed for commit 88608fb1.

Unknowns / Needs Verification

None identified. The PR self-validates by running the updated workflow on its own pull_request event, which is a valid canary pattern.

Recommendation

Approve. The version bump is verified against the upstream release tag. The native_loop mode is opt-in and backward-compatible per upstream release notes. All configuration changes are internally consistent and use the correct secret/variable interpolation syntax. CI has passed. The canary approach is sound — this PR will validate the new config before fanning out to other repos.

@joryirving joryirving merged commit cd4b76e into main Jun 15, 2026
3 checks passed
@joryirving joryirving deleted the chore/pr-reviewer-v1.3.0-native-loop branch June 15, 2026 04:23
joryirving added a commit to misospace/KubeTix that referenced this pull request Jun 15, 2026
…ns (#109)

- Bump the action pin v1.2.9 -> v1.3.0 (3479bf5).
- Switch tool_mode plan_execute_loop -> native_loop (v1.3.0 flagship multi-hop
  harness; requires v1.3.0 for streaming + the in-conversation verdict).
- Wire ai_max_tokens to the org-wide variable: ${{ vars.AI_MAX_TOKENS || '16000' }}.
- Raise per-turn loop budget for the thinking model: tool_planning_max_tokens
  1500 -> 16000, tool_planning_timeout_sec 45 -> 300; add tool_loop_wall_clock_sec 300.

Mirrors the dispatch canary (misospace/dispatch#374).

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
joryirving added a commit to misospace/miso-gallery that referenced this pull request Jun 15, 2026
…ns (#230)

- Bump the action pin v1.2.9 -> v1.3.0 (3479bf5).
- Switch tool_mode plan_execute_loop -> native_loop (v1.3.0 flagship multi-hop
  harness; requires v1.3.0 for streaming + the in-conversation verdict).
- Wire ai_max_tokens to the org-wide variable: ${{ vars.AI_MAX_TOKENS || '16000' }}.
- Raise per-turn loop budget for the thinking model: tool_planning_max_tokens
  1500 -> 16000, tool_planning_timeout_sec 45 -> 300; add tool_loop_wall_clock_sec 300.

Mirrors the dispatch canary (misospace/dispatch#374).

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
joryirving added a commit to misospace/windowstead that referenced this pull request Jun 15, 2026
…ns (#211)

- Bump the action pin v1.2.9 -> v1.3.0 (3479bf5).
- Switch tool_mode plan_execute_loop -> native_loop (v1.3.0 flagship multi-hop
  harness; requires v1.3.0 for streaming + the in-conversation verdict).
- Wire ai_max_tokens to the org-wide variable: ${{ vars.AI_MAX_TOKENS || '16000' }}.
- Raise per-turn loop budget for the thinking model: tool_planning_max_tokens
  1500 -> 16000, tool_planning_timeout_sec 45 -> 300; add tool_loop_wall_clock_sec 300.

Mirrors the dispatch canary (misospace/dispatch#374).

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
joryirving added a commit to misospace/miso-chat that referenced this pull request Jun 15, 2026
…ns (#587)

- Bump the action pin v1.2.11 -> v1.3.0 (3479bf5).
- Switch tool_mode plan_execute_loop -> native_loop (v1.3.0 flagship harness).
- Wire ai_max_tokens to org-wide var: ${{ vars.AI_MAX_TOKENS || '16000' }}.
- Thinking-model loop budgets: tool_planning_max_tokens 1500->16000,
  tool_planning_timeout_sec 45->300; add tool_loop_wall_clock_sec 300.

Mirrors the dispatch canary (misospace/dispatch#374).

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant